better errors if `distributable.url` returns a bad content type

Open ddobrinskiy opened this issue 2 years ago • 5 comments

@mxcl something looks broken in handling the versions, see last part of semver

source code to reproduce: https://github.com/teaxyz/pantry.extra/pull/463/commits/6d4cd3fa65fd02a98de90a39764e9c45cd67fcb9

Mar 06 '23 13:03 ddobrinskiy

oops! my bad, just a malformed URL on my part

Still, it's a bit weird how that is displayed in logs

Mar 06 '23 13:03 ddobrinskiy

Yeah this is a bug in our curl handling, reopening.

Mar 06 '23 13:03 mxcl

Yeah actually I cannot figure out why it doesn’t error cleanly. Is is possible the URL you downloaded returns a HTTP 200 even though it didn’t actually provide a tarball?

Mar 06 '23 13:03 mxcl

@mxcl yes, it indeed returned 200

https://github.com/quarto-dev/quarto-cli/releases/tag/v1.3.242

Mar 06 '23 13:03 ddobrinskiy

right, content type is HTML.

We could probs figure this out and give a better error. Will leave open until we do that.

Mar 06 '23 15:03 mxcl