brewkit icon indicating copy to clipboard operation
brewkit copied to clipboard

`python-venv.sh` script doesn't work with multiple sub directories

Open mfts opened this issue 2 years ago • 7 comments

I'm packging azure-cli and ran into the issue that they have different subdirectories here: https://github.com/Azure/azure-cli/tree/dev/src

mfts avatar Mar 03 '23 17:03 mfts

The new bkpyvenv supports this to some extent. Hard to be sure though since I'm not sure from the report if the issue is that two virtual-environments are needed or if multiple commands need to be provided.

mxcl avatar Jan 07 '24 12:01 mxcl

I don't know if this is related but I ran into an issue with a project named jctl with the error error: Multiple top-level packages discovered in a flat-layout: ['jctl', 'props']. I had to add something to my setup.py file to get around it. https://stackoverflow.com/questions/72294299/multiple-top-level-packages-discovered-in-a-flat-layout

magnusviri avatar Jan 24 '24 00:01 magnusviri

@magnusviri that sounds like it doesn't like the props directory pkgx makes; if you have no props, considering rmdir props or mv props .props and see if it like that better.

jhheider avatar Jan 24 '24 00:01 jhheider

we could probably deprecate props and use the new per array node prop in general since adding files to a build directory is asking for issues like @magnusviri’s

mxcl avatar Jan 24 '24 16:01 mxcl

it's true; the only argument against it is potential bloat in the yaml reducing legibility. possibly only creating the props directory if needed will give the yaml author the control they need.

inlining long/ugly patches doesn't sound fun.

jhheider avatar Jan 24 '24 16:01 jhheider

we could allow the prop: node to take a filename

mxcl avatar Jan 24 '24 18:01 mxcl

well, if we're brainstorming, we could have an build.script[].install { dest, contents, mode? } key, if we needed to keep it "simple".

jhheider avatar Jan 24 '24 18:01 jhheider