update node to 16 and add configurable install command

[alexdor]

[privatenumber]

Thanks for the PR!

Can you share the use-case for customizing the installation command?

Also, ideally dependency upgrades (incl Node) would be in a different PR so it can be discussed and tested in isolation but doesn't seem like a big deal here. Can you set it to Node v14 though? LTS is still active till 2023 April.

[alexdor]

Yeah, absolutely 😊 Our use case is that we are using https://rushjs.io/ for our monorepo. So the command to install the deps would be rush install (which under the hood uses pnpm).

It could be autodetected, but I thought it would cover more use-cases if the users could select their install command (if they wanted to)

I can also split them out in different prs if you prefer that 😊 I went for 16 because recently all the GitHub actions got bumped to 16, but yeah I'll set it to 14 😊

[privatenumber]

Any updates on this?

[JounQin]

I need this one too because I want to use pnpm without lockfile, however it seems impossible for now.

[alexdor]

@JounQin I've been waiting for this to be merged because the current version of the package isn't usable from other libraries

until @privatenumber has had some time to look through things you can use alexdor/[email protected] which is the version with my changes that i've been using

[JounQin]

@alexdor Thanks, I have another proposal at https://github.com/pkg-size/action/issues/49, and it should be implemented at https://github.com/privatenumber/ci, I'll raise a PR for it soon.

[privatenumber]

Thanks for sharing your use-cases. Using npx ci makes sense for when there's a lock file but seems like I over looked the use-cases where there aren't any. That said, I withdraw my suggestion to use npx ci.