eslint-plugin-redux-saga icon indicating copy to clipboard operation
eslint-plugin-redux-saga copied to clipboard

Published 20 hours ago • verified publisher icon pke

no-effect-override rule

Open pke opened this issue 7 years ago • 4 comments

This is a WIP PR to fix #1. The docs are missing.

pke avatar Jul 22 '16 01:07 pke

@sompylasar Now only the docs are missing?

pke avatar Jul 22 '16 10:07 pke

I have added all test cases you mentioned in https://github.com/pke/eslint-plugin-redux-saga/issues/1#issuecomment-234516024 except for the fork stories.

2 good tests are failing now, maybe you can have a look if they are really valid function generator use cases.

pke avatar Jul 22 '16 11:07 pke

We may assume these failing cases as marginal and just really report them as errors. There is no need in the real code to pre-create effects and then yield them later.

sompylasar avatar Jul 22 '16 12:07 sompylasar

Squashed for merge. What do you think? @sompylasar

pke avatar Jul 22 '16 20:07 pke