msgpack-cljs icon indicating copy to clipboard operation
msgpack-cljs copied to clipboard

Unifying with clojure-msgpack

Open rosejn opened this issue 3 years ago • 0 comments

Hi, I've just left a similar message over at the clojure-msgpack issues as well: https://github.com/edma2/clojure-msgpack/issues/29

In short, I've taken your code and started to unify it with clojure-msgpack so that they can share a common interface, extension mechanisms, and most importantly so we can make sure they support a suite of common data types that make sense for Clojure developers. For our application I already added full typed array support so we can transmit large arrays of binary data from JVM Clojure to a web based dashboard. I wanted to ping you to see if you might support this effort? I think having one unified cljc library for msgpack support in Clojure will be helpful to the community, and it will let us really test out their compatibility together.

So far this work is pushed to my fork here: https://github.com/rosejn/clojure-msgpack/tree/cljc and the main bit of work I have left to do is to add some extension points to the clojurescript side so users can add their own data types via multi-methods and/or protocol extensions instead of needing to edit the code directly. I've also refactored both the clj and cljs code slightly to unify the terminology and share some basic protocols and interfaces.

Thanks for you work on this in the past, and I hope this all sounds good to you. I'll take on the remaining issues it seems you had filed for this library, and then publish to clojars once its all cleaned up.

rosejn avatar Jan 21 '22 07:01 rosejn