AudioMass icon indicating copy to clipboard operation
AudioMass copied to clipboard
verified publisher icon pkalogiros

A11y fixes

Open lloydi opened this issue 5 years ago • 3 comments

As per https://github.com/pkalogiros/AudioMass/issues/35

A number of accessibility fixes for AudioMass :)

Summary:

  • Made all buttons keyboard-accessible
  • Added region and group roles
  • Removed maximum-scale restriction to allow users to zoom
  • Made 'load sample' link accessible
  • Added focus styles for all main controls
  • Added a skip link to main toolbar that appears on keyboard focus
  • Added alt attributes for all images

See attachments for some before/after comparisons:

Before: ARC 1 before After: ARC 2 after Before: AXE 1 before After: AXE 2 after Before: Lighthouse 1 before After: Lighthouse 2 after

lloydi avatar Jul 20 '20 20:07 lloydi

Further things I will tackle:

  • Color contrast issues
  • Properly setting buttons active/inactive (so that they are disabled correctly when inactive)

lloydi avatar Jul 20 '20 21:07 lloydi

@pkalogiros - I am keen to engage with blind audio engineers to get some more feedback about how they would use this tool and how they would expect it to work for them. I'm quite keen to get your thoughts on my PR above first, though, as I don't want to raise anyone's hopes needlessly. Would appreciate it if you could take a look at my changes. Thanks

lloydi avatar Aug 05 '20 19:08 lloydi

Not even an acknowledgement?

lloydi avatar Sep 10 '20 00:09 lloydi