sedis icon indicating copy to clipboard operation
sedis copied to clipboard

Fix: a jedis client returning destination

Open kamekoopa opened this issue 12 years ago • 3 comments

A client has to be returned to the broken client pool, when an exception occurred.

kamekoopa avatar Jun 28 '13 15:06 kamekoopa

thanks for this, however, it's not really idiomatic in scala to use a var like this or null.instanceOf could you please modify it using http://danielwestheide.com/blog/2012/12/26/the-neophytes-guide-to-scala-part-6-error-handling-with-try.html ? if not, I will fix it.

Thanks

pk11 avatar Jul 06 '13 11:07 pk11

I tried to fix using the way of error handling that you pointed out. If this fix is inappropriateness, I'm sorry to bother you, but could you please fix this issue yourself?

kamekoopa avatar Jul 06 '13 20:07 kamekoopa

removed duplicate code on @tkawachi 's suggestion, and rebased. (I'm sorry. Target-lines that comment points was disappeared.)

kamekoopa avatar Jul 16 '14 09:07 kamekoopa