PJ Reiniger

Results 16 comments of PJ Reiniger

Also would like to un-snowflake `MemoryBuffer` and `StringExtras`, but that is another issue

> wpi::sgn() gets used a bunch in wpimath and wpilibc. wpi::Lerp() is a shim for C++20's std::lerp(). `` is a c++20 thing and is implemented in wpimath, these both seem...

Another one I forgot to mention was `0003-Wrap-std-min-max-calls-in-parens-for-windows-warning.patch` Is there a reason that `NOMINMAX` is not being defined globally? Its the default for bazels msvc toolchain params, and it removes...

Even if they do, which is really the exception and which is the rule? I reckon the usages of `std::min` are far greater than the usages of gdi. Having a...

I'm aware. I tried vendoring json specifically, and it is NOT easy un-"header-only" and de-templatize the thing. Tylers PR shows how much work has to be done for llvm too....

See new documentation for 2020 https://snobotsimdocs.readthedocs.io/en/latest/index.html

Poor/outdated documentation, Sorry about that. Your dependency block should probably look something like this: ``` dependencies { compile wpi.deps.wpilib() compile wpi.deps.vendor.java() nativeZip wpi.deps.vendor.jni(wpi.platforms.roborio) nativeDesktopZip wpi.deps.vendor.jni(wpi.platforms.desktop) testCompile 'junit:junit:4.12' // SnobotSim snobotSimCompile...

@WWRC-FRC You should be using a newer plugin. I might not have updated the examples, I've been on work travel forever. Here are some recommended settings ``` plugins { id...

Sanity checks: - Are you online? - Are you using gradle 5.0? (If you are using this to deploy to the robot I feel like you have to be) That...

Typically when I point to an invalid release, or am not online it dumps out the website addresses it tries to crawl rather than "Gradle Central Plugin Repository". Might be...