Petri-Johan Last

Results 11 comments of Petri-Johan Last

Buildkite still seems a bit angry

tagging @efritz to maybe just review the DB changes but I think its good Obviously future usernames added with this schema will be incompatible with previous schemas.

@thenamankumar you can maybe just check Buildkite, there's a message explaining how to address the "incompatible changes" to DB schemas

@morgangauth I seem to be unable to replicate this: Do we have any more information on how their setup might differ from what's normal?

@morgangauth ah okay, I see, I did not select "Discover my schema". I adjusted the default attributes based on what's documented here: https://sourcegraph.com/docs/admin/scim#user-attributes . It seems like our schema discovery...

@morgangauth after looking into this I can conclude that our schema is actually correct. The Microsoft SCIM Validator is incorrect. There have been lots of complaints about this in the...

@morgangauth I also want to highlight the actual SCIM Schema: https://datatracker.ietf.org/doc/html/rfc7643 You mentioned the following: > According to [SCIM schema](https://scim.cloud/), the emails schema can be found below, whereas Sourcegraph includes...

Changes look good to me, but probably worth waiting for someone with a bit more ownership

My hunch is that the line length is calculated with a method that treats an emoji as a single character, but then when the highlight is applied the emojis count...

I think the current `0.0.5` release of the cody agent binary (at least for MacOS arm64) is broken. If I build the cody agent binary myself, it works, but the...