ipc-system-simple icon indicating copy to clipboard operation
ipc-system-simple copied to clipboard

IPC::System::Simple adds commas to command line breaking everything

Open wilx opened this issue 11 years ago • 6 comments

I am using autodie which uses IPC::System::Simple. IPC::System::Simple appears to be completely broken on Windows. It adds , (comma) after each command line argument. This is because it does this:

IPC::System::Simple::runx(C:/ActivePerl64/site/lib/IPC/System/Simple.pm:191):
191:            my $pid = _spawn_or_die($command, "$command @args");

The string interpolation seems to do that.

My version is 1.25, using ActivePerl.

wilx avatar Feb 06 '14 11:02 wilx

See also https://github.com/pjf/ipc-system-simple/pull/11

wilx avatar Feb 06 '14 12:02 wilx

Argh, sorry for the noise but it still does not seem to be right. The backslash quoting is odd/wrong.

wilx avatar Feb 06 '14 13:02 wilx

I think this time it is right.

wilx avatar Feb 06 '14 14:02 wilx

Just for reference, these are the rules I have followed to construct this fix: http://msdn.microsoft.com/en-us/library/17w5ykft(v=vs.120).aspx

wilx avatar Feb 06 '14 14:02 wilx

You are awesome, thank you!

It's pretty late in Australia, but I'll see if I can drum up some testers and we'll get this into the next release. Thank you again! :)

~ Paul

pjf avatar Feb 06 '14 14:02 pjf

Ping.

wilx avatar Mar 07 '14 11:03 wilx