Jeongbin Park

Results 46 comments of Jeongbin Park

and also I returned the `test_timestamp` to `testsuite`..

I found that this happens in [line 72 of `magick_cl.cpp`](https://github.com/gnudatalanguage/gdl/blob/master/src/magick_cl.cpp#L72). Indeed this seems to be due to double free. I think #1063 fixes this, I just changed the array to...

@slayoo May I ask if I would do that, or you are already doing it? Thanks!

## Review checklist for @pjb7687 ### Conflict of interest - [x] I confirm that I have read the [JOSS conflict of interest (COI) policy](https://github.com/openjournals/joss/blob/master/COI.md) and that: I have no COIs...

I have also finished my initial review. For me, the library seems to be a dedicated library for internal use rather than a general bioinformatics library. But I think the...

I've run the benchmarks. 1. I had to change below in Makefile: ``` test_kseq: test_kseq.cpp g++ -std=c++17 -fopenmp -pthread -march=native -O3 -flto -lz -lm $< -o $@ -I/projects/btl/vnikolic/miniconda/include -L/projects/btl/vnikolic/miniconda/lib ```...

> I've noticed that downloading sequences from there sometimes takes a bit and is fast at other times. I tried it again yesterday and successfully downloaded the fastq file. >...

![image](https://user-images.githubusercontent.com/1440536/193056616-d71d41b2-758d-4f67-bfca-af0ddaed7991.png) Yes, now I can reproduce the figure. As I mentioned in the above comment, I would like to kindly ask the authors to add just one sentence to clarify...

@slayoo I think it makes more sense to me to deposit the version when we submitted the paper to JOSS, as this is the version of GDL that is actually...

@slayoo I would prefer to create another one as I hesitate to change the author list of the existing one.