Stefan Aebischer

Results 27 comments of Stefan Aebischer

Setting `keepAlive` to `false`, does not fix the issue. After some more debuging i figured out, that during the above scenario `this.#socket` is undefined when [`socket.disconnect`](https://github.com/redis/node-redis/blob/ac7d50c7313fe1158131e13b0e3b11d982697123/packages/client/lib/client/socket.ts#L230). Therefore the `ClientClosedError` is...

@leibale just by looking at #2295 this PR doesn't seem to solve this issue. A call to `disconnect()` should stop the reconnect loop. Maybe a new flag `disconnecting` is needed...

@tikurahul could you check the PR again after my changes regarding your comments?

@tikurahul please let me know if there is something holding you back merging this PR.

Not sure if defaulting to '127.0.0.1' would break any apps relying on '0.0.0.0'. Therfore the best solution might be to allow configuration of the interface with a beautiful default (IMO...

@LoneRifle i just removed the [throw you are mentioning](https://github.com/typeorm/typeorm/blob/f5b93c14b5efa1a55aed0211a4757af1b3d6e66b/src/query-builder/SelectQueryBuilder.ts#L4432-L4434) locally, it wouldn't solve your issue. But you are pretty close. `moreThanOrEqual` and `lessThanOrEqual` should probably be implemented [here](https://github.com/typeorm/typeorm/blob/f5b93c14b5efa1a55aed0211a4757af1b3d6e66b/src/query-builder/SelectQueryBuilder.ts#L4324-L4329) for `relation.isOneToMany`,...

This are the benchmark results on my MBP with 2.9 GHz Intel Core i7 using node.js 10.4.1 **This PR** ``` util.inspect: simple object x 328,495 ops/sec ±1.43% (84 runs sampled)...

This are the benchmark results on my MBP with 2.9 GHz Intel Core i7 using node.js 12.13.1 *This PR* ``` util.inspect: simple object x 273,452 ops/sec ±0.54% (92 runs sampled)...

I understand you, not wanting to support BigInt, as long as JSON.stringify and JSON.parse do not support it. To me the "safe" in fast-safe-stringify relates to "Gracefully handles ... **instead...

> In the CLI we can just try to read the nearest tsconfig.json You would not only have to read the tsconfig.json but also the [`type`](https://www.typescriptlang.org/docs/handbook/esm-node.html#type-in-packagejson-and-new-extensions) in package.json. | tsconfig...