video-compare icon indicating copy to clipboard operation
video-compare copied to clipboard

Add Homebrew formula

Open thomasbachem opened this issue 3 years ago • 15 comments

Great utility to compare results of enhanced videos, thanks for sharing it!

I was about to create a Homebrew formula for it for Mac users, but for some reason that cannot be done easily if the GitHub Repository is a fork, see discussion here.

Since pixop/video-compare isn't really an actual fork of pockethook/player in the typical sense, maybe you could ask GitHub to defork it like described in the thread linked above?

Here's the Homebrew formula btw, it can be created and used locally, but not committed/pushed yet:

class VideoCompare < Formula
  desc "Split screen video comparison tool using FFmpeg and SDL2"
  homepage "https://github.com/pixop/video-compare"
  url "https://github.com/pixop/video-compare/archive/refs/tags/20200724.tar.gz"
  sha256 "9cc3dc2f95a3677316eea7850793cbe2eaf41f620c65474b8c25d2a0f17625fb"
  license "GPL-2.0-only"

  depends_on "ffmpeg"
  depends_on "sdl2"
  depends_on "sdl2_ttf"

  def install
    system "make"
    bin.install "video-compare"
  end

  test do
    output = shell_output("#{bin}/video-compare 2>&1")
    assert_match "Usage: ", output
  end
end

I will keep an eye on this, but am also fine with anyone else committing it to Homebrew.

thomasbachem avatar Apr 01 '21 17:04 thomasbachem

Hi @thomasbachem,

Glad to hear you find this utility useful!

And I'd be happy to help, of course. Let me get in contact with GitHub support and ask them to defork the project.

I'll let you know when the deforking has been done.

jonfryd avatar Apr 05 '21 13:04 jonfryd

Wow, that didn't take long. Big props to GitHub support!

The project is now deforked.

jonfryd avatar Apr 05 '21 13:04 jonfryd

Thanks, sadly Homebrew requires repositories to be more popular/active:

brew audit --new-formula video-compare
video-compare:
  * GitHub repository not notable enough (<30 forks, <30 watchers and <75 stars)
Error: 1 problem in 1 formula detected

So maybe at some point in the future :)

thomasbachem avatar Nov 25 '21 16:11 thomasbachem

Haha, yeah - let's spread the word!

jonfryd avatar Nov 25 '21 17:11 jonfryd

Thanks for looking into it, @thomasbachem.

jonfryd avatar Nov 25 '21 17:11 jonfryd

Hey @thomasbachem,

So I just noticed the project made it to 80 stars. Feel free to re-run the audit check when you have time for it.

Cheers!

jonfryd avatar Mar 29 '22 12:03 jonfryd

Oh, BTW... I'm going to make a change to get rid of the external font dependency.

jonfryd avatar Mar 30 '22 08:03 jonfryd

Oh, BTW... I'm going to make a change to get rid of the external font dependency.

OK, it's been fixed.

jonfryd avatar Mar 30 '22 09:03 jonfryd

Waiting on #14

thomasbachem avatar Apr 12 '22 08:04 thomasbachem

Waiting on #14

Thanks! Merged to the master branch just now.

jonfryd avatar Apr 12 '22 10:04 jonfryd

Great, so the only thing that's missing is a new release :D

thomasbachem avatar Apr 12 '22 11:04 thomasbachem

Great, so the only thing that's missing is a new release :D

Right you are, my friend! ;-)

20220412 has now been released.

jonfryd avatar Apr 12 '22 12:04 jonfryd

I created the pull request for the Homebrew formula :)

Thanks, much appreciated!

jonfryd avatar Apr 16 '22 12:04 jonfryd

Do we need some kind of pure CLI "test mode" option to satisfy the Homebrew formula requirements? It might be as simple as checking we are able to stream a pair of files via avformat and avcodec without opening the main UI window, then returning a string we can assert in the formula if all went well. Who does this sound to you?

I can look into it this weekend. Shouldn't be too hard to do.

jonfryd avatar May 04 '22 20:05 jonfryd