tilemap icon indicating copy to clipboard operation
tilemap copied to clipboard

Improper rendering on retina displays

Open andrewstart opened this issue 9 years ago • 16 comments

When using a retina display (tested on a MacBook with Chrome), the tilemap example renders even more zoomed out, moves faster, and has small gaps between tiles (visibility of gaps changes as camera moves). lineylines

andrewstart avatar May 17 '16 13:05 andrewstart

Its interesting that lines are not aligned with half-tiles and not whole tiles.

ivanpopelyshev avatar May 17 '16 13:05 ivanpopelyshev

Quick video: https://www.youtube.com/watch?v=M_vbfNer0PM

andrewstart avatar May 17 '16 14:05 andrewstart

Is it fixed now, in https://pixijs.github.io/pixi-tilemap/?resolution=2&scale=1.4 ?

ivanpopelyshev avatar May 18 '16 16:05 ivanpopelyshev

No, when the scale (or resolution) is not an integer value, you still have the lines.

andrewstart avatar May 18 '16 16:05 andrewstart

resolution must be 2 for retina. I thought it will work for every scale :(

ivanpopelyshev avatar May 18 '16 16:05 ivanpopelyshev

Some android devices use pixel ratios like 2.5 or 3.5

Jarred-Sumner avatar Apr 12 '20 23:04 Jarred-Sumner

Does it still not work?

ivanpopelyshev avatar Apr 12 '20 23:04 ivanpopelyshev

I'm not actually sure, I was just reading through the open issues on this repo

Jarred-Sumner avatar Apr 12 '20 23:04 Jarred-Sumner

@ivanpopelyshev Hello, I have similar issue on android device with devicePixelRatio = 3, but it happens, only when part of map packed into sprite sheets (with or without tinypng). If each part of map is separate png or sprite sheets which includes only one png it works well. Any idea why? Example from above also gives gaps:(

redgvin avatar Jan 20 '21 16:01 redgvin

@ivanpopelyshev Hello, when are you expecting to merge branch https://github.com/pixijs/tilemap/tree/dev-precision as I see adding precision to shader should fix this issue. Tested on mine and it's helping

redgvin avatar Oct 22 '21 06:10 redgvin

I have a problem with it, I cant build the lib :))))) Im asking @ShukantPal to do that

ivanpopelyshev avatar Oct 22 '21 11:10 ivanpopelyshev

:+1

ShukantPal avatar Oct 22 '21 12:10 ShukantPal

never mind, moving frag/vert files back and making new version

ivanpopelyshev avatar Oct 22 '21 12:10 ivanpopelyshev

Done, 3.2.2. @redgvin please check it

ivanpopelyshev avatar Oct 22 '21 12:10 ivanpopelyshev

@ivanpopelyshev from first testing looks good for all my cases, we will go through QA and more devices and I give you more detail feedback. Many thanks.

redgvin avatar Oct 22 '21 12:10 redgvin

@ivanpopelyshev tested on different devices, it seems working well, I guess you can close an issue

redgvin avatar Nov 03 '21 10:11 redgvin