spine icon indicating copy to clipboard operation
spine copied to clipboard

Argument of type 'Spine' is not assignable

Open rtalon83 opened this issue 3 years ago • 4 comments

I'm playing with your new Spine 3.0.1 version and I have seen a little issue.

const container = new PIXI.Container();
const anim = new Spine(spineData);

container.addChild(anim); // TS2345: Argument of type 'Spine' is not assignable to parameter of type 'DisplayObject'

My simple solution is: @ts-ignore but I think that would you like to check it Thanks!

rtalon83 avatar Apr 30 '21 11:04 rtalon83

https://codesandbox.io/s/pixi-spine-30-test-0iopd - works fine in Parcel.

Please make minimal demo in zip-file so i can find which options are affecting this. Preferably, with your node_modules folder, yes, i know it will be big :)

ivanpopelyshev avatar Apr 30 '21 17:04 ivanpopelyshev

If I can give my 2 cents, I'm having this issue with Pixi 6.1.3. (nothing happens with Pixi 6.1.1).

Together with this issue I also get: Type 'GlowFilter' is not assignable to type 'Filter'.

Using webpack, and

"pixi-filters": "^4.1.5", "pixi-particles": "^4.2.1", "pixi-spine": "^3.0.13", "pixi.js": "6.1.3"

This happens on my production projects, will try to create a small reproduction if I can.

Funnily enough, I was trying npm 7 out, and even though I forced pixi to be 6.1.1, @pixi/app for some reason uses 6.1.3

MercurialUroboros avatar Oct 28 '21 16:10 MercurialUroboros

Looks like you have import doubles. When one module import from one pixi version, other from other pixi version. Types of those imports will always different.

You should check full path of imports and force update all packages (drop node_modules)

eXponenta avatar Oct 28 '21 18:10 eXponenta

I think you are right, In fact, I can't manage to reproduce on a smaller project. Trying to understand where the duplicate happens cause it's not that I have many packages on the production branch 👀

MercurialUroboros avatar Oct 29 '21 09:10 MercurialUroboros