node icon indicating copy to clipboard operation
node copied to clipboard

Add names to load parsers

Open UlyssesZh opened this issue 2 years ago • 2 comments

I think this is a fair enough change? It is simple enough, so I did not open an issue but opened a pull request directly.

Sometimes I need to specify the load parser explicitly when using Assets.load, but it is difficult in Node.js because those extension load parsers in @pixi/node do not have names. This pull request fixes this problem.

UlyssesZh avatar Jan 03 '24 21:01 UlyssesZh

@UlyssesZh your PR just pointed me in the right direction. I stumbled over the load naming issue today and I was very suprised that not all parsers were available as in "normal" PIXI.

My suggestion would be to stick to the original names so JS code will be compatible with both version: e.g. loadNodeTexture should still be loadTextures

Really appreciate your inspection and work on that - thanks!

unic8s avatar Oct 10 '24 22:10 unic8s

My suggestion would be to stick to the original names so JS code will be compatible with both version.

Good suggestion, but there are possible counterarguments to this. Let's wait for opinions from other contributors or project owners.

UlyssesZh avatar Oct 10 '24 22:10 UlyssesZh