letsencrypt-rails-heroku icon indicating copy to clipboard operation
letsencrypt-rails-heroku copied to clipboard

Fixed domain wildcard issues

Open kaspernj opened this issue 7 years ago • 2 comments

Closes #39

I have implemented two options to fix the wildcard domain issue:

  1. The Rake task chooses a domain that isn't a wildcard
  2. You can supply the domain you want used through an extra environment variable called HEROKU_APP_DOMAIN

kaspernj avatar Feb 28 '17 15:02 kaspernj

I can confirm this fixes my own wildcard issues, that I mentioned in the original issue.

kaspernj avatar Feb 28 '17 15:02 kaspernj

Thanks @kaspernj. For now can we split this in two and have one PR for fixing the wildcard issue, and another for introducing the HEROKU_APP_DOMAIN variable? Because the latter is part of a wider discussion around how we utilise ACME_DOMAIN (when provided).

jalada avatar Mar 11 '17 00:03 jalada