pixie icon indicating copy to clipboard operation
pixie copied to clipboard

Fix GolangDwarfReaderTest.FunctionVarLocationConsistency

Open vihangm opened this issue 2 years ago • 1 comments

Describe the bug The GolangDwarfReaderTest.FunctionVarLocationConsistency test only runs a go1.16 binary despite the parametrization suggesting that it works on various versions. See binary override here

I updated the test to run on binaries compiled with other versions of go and the test fails. I am unsure if this is a bug and the test setup was an oversight or if this functionality isn't expected to work beyond go version 1.16

As part of removing go 1.16 from our build toolchain, I am going to update the test to keep it around and make it parametrize across all versions of go, but disable the test. We should investigate the test and fix the code/testcase or remove it.

To Reproduce Steps to reproduce the behavior:

  • Remove the DISABLED_ prefix from FunctionVarLocationConsistency in src/stirling/obj_tools/dwarf_reader_test.cc
  • Run the test

Expected behavior The test should pass.

vihangm avatar Feb 10 '23 02:02 vihangm

While working on a related area (#2207), I found a potential fix for this.

Saving my work here until I have time to clean it up and open a PR for it.

ddelnano avatar Jun 09 '25 18:06 ddelnano