pixie icon indicating copy to clipboard operation
pixie copied to clipboard

[Parse incomplete chunks 2/9] Add chunk type annotations, record gap sizes and filler allocations

Open benkilimnik opened this issue 2 years ago • 1 comments

Summary: Adds metadata to socket_data_event_t to keep track of gaps from bpf along with the number of bytes we miss. This metadata will be fed to prometheus in a future PR to keep track of the prevalence and distribution of gaps on a per protocol basis. More details in #1755.

Type of change: /kind feature

Test Plan: Existing targets (including qemu bpf tests for kernel versions < 5.1 and > 5.1). Skaffolded to cluster running kernel > 5.1.

benkilimnik avatar Nov 29 '23 21:11 benkilimnik

@etep Could you give an approval if you think this is good to go

@benkilimnik If you've done additional testing to ensure that this works (eg. on kernels older than 5.1 and kernels newer than 5.1), could you add it to the Test Plan in the PR description. If we haven't done that, I think it would be good to ensure that things work end to end, when we change bpf code.

JamesMBartlett avatar Jan 23 '24 06:01 JamesMBartlett