pixie icon indicating copy to clipboard operation
pixie copied to clipboard

Support calling predefined PxL scripts by name in pxapi

Open caphrim007 opened this issue 2 years ago • 2 comments

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

The Golang SDK has a NewVizierClient that returns a pxapi.VizierClient that has a method ExecuteScript(ctx context.Context, pxl string, mux TableMuxer), but the pxl string cannot take a function like px/perf_flamegraph; it only take real pxl scripts.

Describe the solution you'd like A clear and concise description of what you want to happen.

Can functionality be added to allow passing a name of a function that is stored in the cluster rather that raw pxl? I'm impartial to whether this is part of the existing ExecuteScript function, or, if a new function is added to support this functionality. New function might make more sense than overloading existing functionality.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

We are not aware of alternatives except putting the functions we need into a PxL script itself.

Additional context Add any other context or screenshots about the feature request here.

We are using the Golang SDK, but I assume this functionality would want to be applied to any of the available SDKs

caphrim007 avatar May 09 '23 20:05 caphrim007

I assume by "functions" you're talking about calling existing PxL scripts, like px/perf_flamegraph rather than actual functions within a PxL script. Is that correct?

JamesMBartlett avatar May 09 '23 21:05 JamesMBartlett

yeah, for the purposes of this issue that's correct

caphrim007 avatar May 09 '23 21:05 caphrim007