Please fix the Redis store_many_vectors_case

[pixelogik]

@xieqihui Sorry for the hassle.

Could you please create a new pull request for your store_many_vectors addition and make this little adjustment I suggested, so that store_many_vectors works even if not Redis is used for storage?

[xieqihui]

I have fixed this according to your suggestion in https://github.com/pixelogik/NearPy/pull/76. Can you check it again?

[pixelogik]

@xieqihui Thanks! Could you do me one more favor and add tests for the new method store_many_vectors ? Sorry for not mentioning this before, but now that more people are working on NearPy we should take care of the tests for real.

[xieqihui]

I’m working on the tests.

Best regards, Qihui

From: Ole [email protected] Reply-To: pixelogik/NearPy [email protected] Date: Wednesday, 7 February 2018 at 10:42 PM To: pixelogik/NearPy [email protected] Cc: Qihui Xie [email protected], Mention [email protected] Subject: Re: [pixelogik/NearPy] Please fix the Redis store_many_vectors_case (#75)

@xieqihuihttps://github.com/xieqihui Thanks! Could you do me one more favor and add tests for the new method store_many_vectors? Sorry for not mentioning this before, but now that more people are working on NearPy we should take care of the tests for real.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/pixelogik/NearPy/issues/75#issuecomment-363789671, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AUGNID_Y6rvxCDWZOkxaZtW0igNct0BPks5tSbZVgaJpZM4R7J9-.