Gregor Adams

Results 184 comments of Gregor Adams

``` output: /Users/greada/Documents/workspace/sinner/dekk/docs/api/class/@dekk/deck/src/deck.js~Deck.html SyntaxError: Invalid regular expression: /[~](String$/: Unterminated group at new RegExp () at ClassDocBuilder._findByName (/Users/greada/Documents/workspace/sinner/dekk/node_modules/esdoc-publish-html-plugin/out/src/Builder/DocBuilder.js:116:20) at ClassDocBuilder._buildDocLinkHTML (/Users/greada/Documents/workspace/sinner/dekk/node_modules/esdoc-publish-html-plugin/out/src/Builder/DocBuilder.js:768:22) at ClassDocBuilder._buildTypeDocLinkHTML (/Users/greada/Documents/workspace/sinner/dekk/node_modules/esdoc-publish-html-plugin/out/src/Builder/DocBuilder.js:748:23) at inner.split.map.v (/Users/greada/Documents/workspace/sinner/dekk/node_modules/esdoc-publish-html-plugin/out/src/Builder/DocBuilder.js:708:28) at Array.map () at...

Crashes: ``` * @return {{children: (ReactElement|ReactElement[]), animation: ?(String|Array), order: ?number}} ``` Works: ``` * @return {{children: (ReactElement|ReactElement[]), animation: (String|Array), order: ?number}} ``` difference: ``` ?(String|Array) => (String|Array) ```

It could be that either of the plugins is needed: * [esdoc-standard-plugin](https://github.com/esdoc/esdoc-plugins/tree/master/esdoc-standard-plugin) * [esdoc-publish-html-plugin](https://github.com/esdoc/esdoc-plugins/tree/master/esdoc-publish-html-plugin) * [esdoc-publish-markdown-plugin](https://github.com/esdoc/esdoc-plugins/tree/master/esdoc-publish-markdown-plugin) I'm not sure but it would make sense that this changed when esdoc switched...

Wow. All this discussion would not have to be if there was a simple explanation of what the different properties in the `sourceMap` object do and a simple example for...

Always ready to create PRs but I still don't fully understand how it works. I'll create a PR when I figured it out.

@matthew-dean thx. That's a good hint. I'll look into it.

@seven-phases-max thx for the clarification, so to make the documentation valid, you'd suggest looking at the source code? Can you point me to the correct file/line-number or link a comment...

@bircha this plugin is so old and dirty I recommend not using it. The code is filled with potential bottlenecks and performance hungry unneeded parts. There is an intense use...

I didn't intend to offend you but the code is outdated. Why are there several slow String() calls when they're not needed. Why are conditionals so deeply nested and don't...