packages icon indicating copy to clipboard operation
packages copied to clipboard
verified publisher icon piwheels

Missing package: simplepyble

Open kdewald opened this issue 2 years ago • 8 comments

Package name

simplepyble

Package version

all

PyPI URL

https://pypi.org/project/simplepyble/

piwheels URL

https://www.piwheels.org/project/simplepyble/

Python version

  • [X] Python 3.7
  • [X] Python 3.9

I am the maintainer

  • [X] Yes

More information

SimplePyBLE is a Python wrapper of SimpleBLE, which uses libfmt as a third party dependency.

According to the error described in the build log, the runner is not able to clone the corresponding libfmt repository and the build fails.

kdewald avatar Mar 13 '23 16:03 kdewald

It's a missing package - updated title accordingly.

The problem is that the package tries to run a git clone as part of its build procedure, which we do not allow.

You'll have to raise an issue with the package maintainers and suggest that they use packaged software (apt or pypi) rather than relying on code on GitHub.

bennuttall avatar Mar 13 '23 17:03 bennuttall

That's good to know, thanks @bennuttall for the info.

I'm the maintainer of the package, so I do have a few questions in order to proceed:

  • I'll need to install libfmt-dev and libdbus-1-dev from apt, how can I specify that?
  • Is there a way I can recognize that I'm being built by pywheels? (That way I can redirect the build process to use system packages instead)

kdewald avatar Mar 15 '23 02:03 kdewald

I just installed libfmt-dev on one and it built successfully. I can add it to the build script and roll it out to builders and then kick off a rebuild and we should be good :+1:

bennuttall avatar Mar 15 '23 12:03 bennuttall

Oh, that's me being dumb. I forgot that running pip wheel manually didn't reject git clones, so that's still a problem.

Is there a way I can recognize that I'm being built by pywheels? (That way I can redirect the build process to use system packages instead)

We now set the environment variable PIWHEELS_BUILD: https://github.com/piwheels/piwheels/pull/326/files

bennuttall avatar Mar 15 '23 15:03 bennuttall

Oh, that's me being dumb. I forgot that running pip wheel manually didn't reject git clones, so that's still a problem.

Is there a way I can recognize that I'm being built by pywheels? (That way I can redirect the build process to use system packages instead)

We now set the environment variable PIWHEELS_BUILD: https://github.com/piwheels/piwheels/pull/326/files

That's awesome! Let me make the changes on my end and see how it works. I'll keep you posted.

kdewald avatar Mar 15 '23 15:03 kdewald

That seems to have worked.

Buster failed to install due to missing libfmt: https://www.piwheels.org/logs/0000/0947/9153.txt

But Bullseye worked, so it seems we're almost there :D

kdewald avatar Mar 19 '23 01:03 kdewald

@bennuttall no hurry on my end, but wanted to make sure you had seen the message above :D

kdewald avatar Mar 23 '23 15:03 kdewald

I'm not sure what the cause of the failure is. I installed libfmt-dev: https://packages.debian.org/buster/libfmt-dev

bennuttall avatar Mar 30 '23 12:03 bennuttall