throwing-function icon indicating copy to clipboard operation
throwing-function copied to clipboard

Add module info to final jar

Open bowbahdoe opened this issue 1 year ago • 1 comments

This adds a module-info to the final jar under META-INF/versions/9. It will not affect compatibility with Java 8

This will enable downstream libraries (i'm looking at https://github.com/bbottema/simple-java-mail now) to have module infos of their own and for consumers to use jlink.

bowbahdoe avatar Apr 04 '24 15:04 bowbahdoe

Oh, thanks - that's a good point. I haven't released it in a while. Now it's a good opportunity!

pivovarit avatar Apr 04 '24 15:04 pivovarit

I ended up adding Automatic-Module-Name to manifest - that's the easiest solution here that doesn't require any additional plugins. It's also viable because the whole library is just one package with a couple of public interfaces

https://github.com/pivovarit/throwing-function/releases/tag/1.6.0

pivovarit avatar Sep 25 '24 06:09 pivovarit

@pivovarit Just so you are aware that doesn't solve the issue of usage with jlink

bowbahdoe avatar Sep 25 '24 12:09 bowbahdoe

image

bowbahdoe avatar Sep 25 '24 12:09 bowbahdoe

🤦‍♂️I guess I will need to try again with your approach. Could you perhaps recreate this Pull Request? for some reason, CI jobs never got triggered here. I tried rebasing, but it did not do the trick

pivovarit avatar Sep 25 '24 12:09 pivovarit