LicenseFinder icon indicating copy to clipboard operation
LicenseFinder copied to clipboard

v6.6.1 breaks license approval

Open svewag opened this issue 4 years ago • 3 comments

Before v6.6.1 we had a permitted license called (MIT and Zlib) in our dependency_decisions.yml and everything was fine. With v6.6.1 the check now says that it needs an approval for this license.

We fixed the check by adding MIT and Zlib as permitted licenses to the dependency_decisions.yml.

I think this does not work as expected and should be fixed.

Thank you for your feedback and awesome work 🙏

svewag avatar Jul 08 '20 18:07 svewag

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

cf-gitbot avatar Jul 08 '20 18:07 cf-gitbot

Hey @svewag ! Does this PR fix this issue? https://github.com/pivotal/LicenseFinder/pull/762 Im planning on doing a release tomorrow

xtreme-shane-lattanzio avatar Jul 08 '20 20:07 xtreme-shane-lattanzio

hmm maybe, I will try it out in the next release.

Thank you!

svewag avatar Jul 09 '20 14:07 svewag