LicenseFinder icon indicating copy to clipboard operation
LicenseFinder copied to clipboard

Dotnet seems not trigger

Open josselinchevalay opened this issue 4 years ago • 7 comments

Hello,

i create a plugin for gradle gradle-license_finder-plugin whe i use that on java project (gradle) work fine, but with dotnet project i see that

Task :reportLicensesToJson
LicenseFinder::Dotnet: is active
LicenseFinder::Dotnet: is not installed

when i run directly on my machine i see

LicenseFinder::Dotnet: is active
LicenseFinder::Dotnet: is installed

so i decide to check command generate by gradle plugin and i have that license_finder --project-path=./src so when i run this command into my gradle plugin i can't see licenses of my dependencies but when i run directly on my machine same command i see all licenses of dependencies.

Any idea ?

josselinchevalay avatar Mar 12 '20 08:03 josselinchevalay

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

cf-gitbot avatar Mar 12 '20 08:03 cf-gitbot

@josselinchevalay I think there are two things going on here. For the gradle part, make sure you are following the Gradle Projects part of the README.md. Here

For the dotnet thing, we will need to look into why the dotnet library is not installed in the LicenseFinder docker image. Do you have a sample dotnet project that you were working on that you could give us to try out? Thanks!

xtreme-shane-lattanzio avatar Apr 13 '20 20:04 xtreme-shane-lattanzio

@josselinchevalay Could you please tell us if the system you ran license_finder had dotnet installed?

For license finder, a project is active if it contains relevant package manager files(*.csproj in this case). So even though dotnet command is not present, a project will be reported as active but license finder will also print the status for package management command not installed.

The license finder docker image has these installed, is that where you are running license_finder?

xtreme-vikram-yadav avatar Apr 22 '20 16:04 xtreme-vikram-yadav

good morning,

I'll give you a little context. In my company we're based on javaists. But we've had to do DotNet projects for clients. Since we are very java oriented we build all our projects with gradle even DotNet projects we have created a gradle plugin for msbuild. On my machine for example if I run license_finder directly on a java project + gradle it works fine, if I always run a live gralde project + DotNet it works too. but we need in our build process to integrate your license report in our package and for that we have open sourcer a gradle plugin to run the command license_finder in a gradle process the code is here. with this plugin the java + gradle project works well but in this case the DotNet + gradle project doesn't work. so I summarize:

  • live (I open a command line and launch license_finder) both cases works.
  • In gradle (the process gradle [process java]) launches the command which it enriches with parameters: works only in the case java + gradle.

let me know if you need more details

Regards

josselinchevalay avatar Apr 27 '20 09:04 josselinchevalay

It sounds difficult to reproduce your unique use case.

Would you be able to provide a sample project? A minimal public repo for a dotnet project with a gradle file that uses your plugin, plus the command you would run to reproduce the issue.

danger-ranger avatar Apr 28 '20 15:04 danger-ranger

I created a sample project with gradle and dotnet you can see the sources here. But it works well in my sample project with gradle and direct command line. I'm a bit confused. I need to discuss with my team about this problem and I'll let you know if I find out why or if I need help. On the other hand now you with a gradle plugin for your project :tada:

josselinchevalay avatar Apr 29 '20 08:04 josselinchevalay

intresting thing we use windows as a os and with have on all machine git bash installed and when we run with git bash seems we have the issue. with windows cmd both case seems works

josselinchevalay avatar Apr 29 '20 12:04 josselinchevalay