PantherView icon indicating copy to clipboard operation
PantherView copied to clipboard

Display invalid markers in a separate sidebar

Open mbilker opened this issue 7 years ago • 9 comments

Currently, invalid entries from the data sources are stored without marker.pin and never displayed through a check that marker.isMapped === true.

This PR proposes to display these markers in a separate sidebar on the right side. The design of the entry display in this new sidebar is not final, but the code to display the entries in the sidebar is working.

mbilker avatar Mar 15 '17 22:03 mbilker

I only saw some unmapped police records, but maybe they are older than 30 days now.

mbilker avatar Mar 17 '17 20:03 mbilker

Should I add a media query to hide the unmapped records section on mobile?

mbilker avatar Mar 17 '17 20:03 mbilker

Also, should I make the unmapped records section hideable?

mbilker avatar Mar 17 '17 20:03 mbilker

Ideally it should behave just like the other sidebar: shown as closed on mobile with a button to expand/contract on both mobile and desktop

vonbearshark avatar Mar 17 '17 20:03 vonbearshark

@vonbearshark I see that the table function now returns HTML in the form of <td> elements. Would it be better to return an array?

mbilker avatar Apr 11 '17 00:04 mbilker

cc @seifriedc ^^

mbilker avatar Apr 11 '17 00:04 mbilker

An array? An array of what exactly? The table function is run on each individual cell, not all of them at once, no?

Also, is this ready?

vonbearshark avatar Apr 11 '17 15:04 vonbearshark

@vonbearshark The table method returns td elements like:

<td>text</td><td>asdjfa</td><td>jaldsjfla</td>

I was thinking it could return:

['text','asdjfa','jkasjfdl']

mbilker avatar Apr 11 '17 20:04 mbilker

@mbilker Are you initial commits associated with "displaying invalid markers in a separate sidebar" ready? If so I can merge this PR and we can worry about returning an array of elements for the table in an issue (I think that's where that problem should go).

In that issue, please detail what we would gain from returning an array of elements like you propose.

kingsman142 avatar Jun 01 '17 22:06 kingsman142