Peter Vernigorov

Results 40 comments of Peter Vernigorov

damn, it's a bit more complicated than what I thought. I'd have to [find all commits](https://developer.github.com/v3/pulls/#list-commits-on-a-pull-request) per [every pull request](https://developer.github.com/v3/pulls/#list-pull-requests). N+1 HTTP request problem. Doesn't seem like a godd idea...

GitHub support suggested we use their issue search api and query quth commit sha. Something like `https://api.github.com/search/issues?q=08e7991%20repo:zendesk/samson` would return the following: ``` json { "total_count": 1, "items": [{ "html_url": "https://github.com/zendesk/samson/pull/210",...

@fneves good idea using local repo. Pull Request API returns head and base commit sha, so it's a matter of checking which commits are part of which `base..head`.

cache would still be needed as I understand it, as the favicon will be lost next time you reopen bookmarks sidebar or restart browser

FYI you can use [nginx ssl preread module](http://nginx.org/en/docs/stream/ngx_stream_ssl_preread_module.html) instead, which I discovered when I needed a similar functionality. I believe Apache has something similar. I use this on glv.one with...

Not quite. My understanding is that it works on tcp level, and only peeks into the tls layer to look at the ClientHello message.

bump. would love some feedback on this

build looks good, it looks like 1.9.2 got stuck during `bundle install` phase. @tjackiw can you restart the build/merge