nodebb-plugin-calendar icon indicating copy to clipboard operation
nodebb-plugin-calendar copied to clipboard

Added ical import

Open Fank opened this issue 6 years ago • 9 comments

What if done:

  • Redesigned admin view to match more material style
  • Added option to add icals

... and maybe forgot something

TODO:

  • [x] Add cronjob for pulling the icals, to local storage. So calander view can be open faster.
  • [ ] Add option to see the added icals @pitaj
  • [ ] Add option to deleted the added icals @pitaj
  • [x] Test everything to verify nothing is messed up

Fixes #46

Tested icals:

  • http://c.opencritic.com/calendar/OpenCritic.ics
  • http://www.chrisgregori.co.uk/playdate/export.php

image
image
image

Preview deployed: https://fankserver.com/calendar

Fank avatar Jul 21 '17 19:07 Fank

@pitaj could you please review the changes i made while i try to complete it?

Fank avatar Jul 21 '17 19:07 Fank

I'm really wondering why these diffs are messed up so bad. Any idea why?

pitaj avatar Jul 23 '17 18:07 pitaj

Maybe whitespace changes i did some, try to hide whitespace changes. I think its ?w=1

Fank avatar Jul 23 '17 19:07 Fank

@pitaj I think i'm done for now, tested a lot of stuff and looks like everything works. There are some things which should be improved for later:

  • Rename "ical" and "externalevent" to something more global, to support jcal, ....
  • Add styles to show calendar entries in different color foreach imported calendar.
  • Add "Tag" as a prefix to the event name to easily determine from which imported calendar it came from.
  • TBD

Fank avatar Jul 24 '17 20:07 Fank

Any interest in getting this cleaned up? I could take a look at the conflicts and test it

ghost avatar Sep 07 '21 13:09 ghost

This is mine? Amazing ...

@robjloranger i think i will not continue on this anymore, becaue i don't even use nodebb anymore, feel free to pick it and adjust it freely. I also added you as contributor to my repository.

Fank avatar Sep 07 '21 13:09 Fank

This is mine? Amazing ...

@robjloranger i think i will not continue on this anymore, becaue i don't even use nodebb anymore, feel free to pick it and adjust it freely. I also added you as contributor to my repository.

Thank you, I will start this evening.

ghost avatar Sep 07 '21 13:09 ghost

@pitaj would you say it is worth it to try an merge 1.0.x into these changes and go from there, or better to start fresh off of main and replicate the changes within the current codebase? it's looking like a lot has changed since 2017 :grin:

ghost avatar Sep 08 '21 04:09 ghost

Probably easiest to start fresh.

pitaj avatar Sep 08 '21 13:09 pitaj