Sonja Heinze

Results 184 comments of Sonja Heinze

I've just seen this. With the change to Astlib, on new compilers I have indeed replaced `(Longident.parse x)` with `(Parse.longident (Lexing.from_string x))` now (see [here](https://github.com/ocaml-ppx/ppxlib/blob/master/astlib/longident.ml#L5)). @jeremiedimino , what did you...

Ok, I see. In `Astlib` that should be fine then since I've called that function `Longident.parse`. I'll leave this open though, since the confusion you're describing is still in `Ppxlib.Ast_builder`.

Thanks for the idea. It will be good to discuss this. There are a couple of reasons why I'd rather not do this: - it wouldn't allow us to follow...

To come back to this, @NathanReb has mentioned that there has been an idea around for a while in this context that sounds very convincing to me. We could create...

> I'm assuming that you're sending patches to published projects on opam. Yes, you're right: we're only checking published projects.

Yes, thanks for opening the issue (and pinging me)! We definitely need to revamp our documentation (including the manual) and it's good to list what we're planning to do in...

@Kakadu, there's also a section in our manual on metaquot: https://ppxlib.readthedocs.io/en/latest/ppx-for-plugin-authors.html#metaquot. I think from your comment it's quite clear that you didn't find that section so far (which is a...

Ok, yes, I agree. I'll write an issue this week pointing out which things I think need to be added so that that can be discussed.

cc @panglesd who might be interested in implementing part(s) of this issue as part of his on-boarding at Tarides (not related to Outreachy) :)

> I submitted a first PR #289 for the first task: writing tests to verify the current behaviour. Thanks, the tests are great! I'll check the first check box of...