Sonja Heinze

Results 184 comments of Sonja Heinze

Hi @PizieDust , this looks awesome! It could significantly improve the experience of people setting up OCaml. Would it be easy to drop a quick screencast of the walkthrough here?...

Hi @smorimoto , I was wondering: Is there anything we haven't noticed that is blocking this from getting merged?

> but basically I'm not in a position to decide when we add a new feature though. And who is in the position to decide that? @rgrinberg ?

> How confident are we about the stability of this feature? Do you mean the stability of this feature on the vscode side? Or of @PizieDust's implementation? > If something...

> No, I meant just running a version of the vscode extension with this PR enabled. It's quite hard to write effective tests for vscode plugins, so we have to...

Thanks for the issue! I wasn't sure myself, so I've just had a look at the compiler Parsetree module. There are few Parsetree invariants that aren't enforced by the type...

Sounds good to me! Having logic inside the ppxlib driver to know whether it has actually done any transformation or not can end up being useful in a lot of...

Sorry for the delay in replying. Emitting errors about untouched attributes on stderr instead of embedding them in the AST is a very good point! I think the current situation...

Thanks for the comment, @AllanBlanchard! It's important for us to know that this problem is hitting people in the real world. > in particular, the location of the error was:...

Hi @marrious11, let me follow up on [our conversation about growing/learning via open-source contributions](https://github.com/ocaml-ppx/ppxlib/pull/410#issuecomment-1496653377) on this issue dedicated to Outreachy-related conversations. The skills you're mentioning sound great and are indeed...