gensim icon indicating copy to clipboard operation
gensim copied to clipboard

Docs still reference fasttext.build_vocab sentences parameter

Open Jeff-Winchell opened this issue 1 year ago • 1 comments

Current version of Fasttext.build_vocab method has a first parameter with two possible names, neither of which is "sentences" despite that 2+ year-old (pre version 4) parameter name being listed on https://radimrehurek.com/gensim/models/fasttext.html

Jeff-Winchell avatar Oct 31 '23 04:10 Jeff-Winchell

Yep, see #3152. PRs that ensure the preferred, explicit 'corpus_iterable' & 'corpus_file' are used everywhere (while the 'sentences' doesn't break where it was working in any 4.x) – & docs match, showing 'sentences' as deprecated – would make sense to me.

gojomo avatar Nov 05 '23 03:11 gojomo