pisa

pisa copied to clipboard

Opening this for discussion.

elshize

Convert into a constexpr unordered_map

1

https://github.com/pisa-engine/pisa/blob/c421f3d4cd72883e66212692e1cc887a83c3d326/include/index_types.hpp#L50-L56 This can be converted into a constexpr map, s.t. the following can be implemented with a table lookup. https://github.com/pisa-engine/pisa/blob/8177a472f770d50e09676d68fbe74a97c657985d/benchmarks/selective_queries.cpp#L67-L78

amallia

We should start to use https://github.com/google/benchmark

amallia

`std::iterator` was deprecated in C++17. It should be replaced by explicitly defining iterator traits. More details here: https://www.fluentcpp.com/2018/05/08/std-iterator-deprecated/https://www.fluentcpp.com/2018/05/08/std-iterator-deprecated/ I noticed it when my compiler started throwing warnings at me around...

elshize

Clang 16 (c++20) build in CI fails: https://github.com/pisa-engine/pisa/actions/runs/7865449374/job/21458386783 ``` 65.16 -- Compiling and running to test HAVE_POSIX_REGEX 65.20 -- Performing Test HAVE_POSIX_REGEX -- failed to compile ```

elshize

This is a tracking issue for the stable release. We will link other issues here so that it is possible to follow the progress in one place. --- [PISA v1...

elshize

**Describe the solution you'd like** There is a bunch of prior work on splitting postings lists; this allows the high impact list to be traversed (more likely) than the low...

JMMackenzie

how can we get the benchmark dataset that pisa paper used

3

chasingegg

`--range` excludes `-b` and `-l` but those are bundled in a required group, so there is no way to actually pass `--range` without triggering an error. I didn't fix it...

elshize

`interpolative_block` codec uses a `thread_local` vector buffer. If we can figure out the upper bound on the length of this buffer, we could use `std::array` that is likely to improve...

elshize