pisa

pisa copied to clipboard

I think we should call `fill_buf` in the constructor here: https://github.com/pisa-engine/pisa/blob/master/include/pisa/bit_vector.hpp#L358 Otherwise, if you call `skip_zeros` right after construction, it will never put anything in the buffer, and fail (or...

elshize

Sharding with customized doc-shard mapping

1

Hi, I am now trying to use PISA on selective search research and confused about the shard operation. When using the --shard-file option, what format of the **shard-file** should be...

saltonz

The following warning is generated: ``` /home/travis/build/pisa-engine/pisa/include/pisa/invert.hpp:74:47: required from here /home/travis/build/pisa-engine/pisa/external/range-v3/include/range/v3/view/iota.hpp:93:199: warning: ignoring return value of 'pisa::Integer pisa::Integer::operator-(const pisa::Integer&) const [with Tag = pisa::document_id_tag; T = int; T default_value =...

amallia

**Describe the solution you'd like** `stxxl` is only used by `optimal_hybrid_index.cpp` to perform external sorting. Find a better alternative (`stxxl` is not maintained anymore) and replace it.

amallia

Currently, `compute_intersection` with `--combinations` prints out all combinations, even empty ones. We should add a condition that doesn't print out an intersection if `intersection.length == 0` because it means effectively...

elshize

There are still two buffer overflows (seem to be reads right after allocated memory): test_bmw_queries in https://github.com/pisa-engine/pisa/blob/master/include/pisa/score_opt_partition.hpp#L90 test_block_codecs in https://github.com/pisa-engine/pisa/blob/master/include/pisa/codec/interpolative_coding.hpp#L98 Also, there is still one error from the static analyzer....

amallia

Address sanitizer failures

2

A number of tests fail when run with address sanitizer. Note that some might be due to TBB problems but there are definitely some that are strictly in our code....

elshize

MaxScore bug

6

**Describe the bug** I suspect there is a bug in MaxScore. https://github.com/pisa-engine/pisa/blob/f8c65c16342537237ce3bc877bec3cbf6d006172/include/pisa/query/algorithm/maxscore_query.hpp#L40-L67 `non_essential_lists` is unsigned and initialized to `0`. In line 63 we do: `size_t i = non_essential_lists - 1;...

amallia

Rename tools for 1.0

2

@amallia @JMMackenzie Let's discuss. | Current Name | Proposal | | --- | --- | | `compute_intersection` | `intersect` | | `create_freq_index` | `compress` | | `create_wand_data` | | |...

elshize

Bugs found with Clang static analyzer

1

Logic error | Dereference of null pointer | include/pisa/bit_vector.hpp | skip | 426 | 29 | View Report | Report Bug | Open File -- | -- | -- |...

elshize