pisa icon indicating copy to clipboard operation
pisa copied to clipboard

topk_queue::finalize sorts by both score and ID (#508)

Open elshize opened this issue 2 years ago • 1 comments

The final sorting order is now by score (descending) and docid (ascending). Furthermore, std::push_heap is replaced with our own implementation to maintain consistency across standard libraries.

Fixes #508

elshize avatar Jan 25 '23 00:01 elshize

Codecov Report

Base: 93.06% // Head: 93.06% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (a371736) compared to base (734ed9f). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head a371736 differs from pull request most recent head 6f9d4bb. Consider uploading reports for the commit 6f9d4bb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #515      +/-   ##
==========================================
- Coverage   93.06%   93.06%   -0.01%     
==========================================
  Files          90       90              
  Lines        4497     4511      +14     
==========================================
+ Hits         4185     4198      +13     
- Misses        312      313       +1     
Impacted Files Coverage Δ
include/pisa/topk_queue.hpp 100.00% <100.00%> (ø)
include/pisa/wand_data_range.hpp 83.33% <0.00%> (-1.29%) :arrow_down:
include/pisa/type_safe.hpp 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jan 25 '23 01:01 codecov[bot]