Redundant quantize flag?

[elshize]

Somehow, we ended up with two quantization options for queries. First, we have --quantized, and then we have --scorer quantized. I think the easier way would be to remove --quantized because the other takes part in scorer resolution directly. The alternative is to have exactly one of the options required because saying --scorer bm25 --quantized makes no sense.

[amallia]

It is not exactly redundant. --quantized is used by https://github.com/pisa-engine/pisa/blob/master/include/pisa/wand_data_compressed.hpp

If --quantized is passed, when block upper bound scores are computed they do not need to be unquantized. Please note that in https://github.com/pisa-engine/pisa/blob/master/include/pisa/wand_data_compressed.hpp scores are stored quantized.

We could find a way to pass it only once to the CLI, but we will need to pass it down to wand_data_compressed anyway.

[elshize]

I understand, but we can easily use auto quantized = scorer_name == "quantized" and pass it along. The point is to have the command arguments that make sense. I've been trying to run quantized queries with --quantized and it just spit out some garbage results because I didn't also say -s quantized. This is not a nuclear weapon, we don't need two triggers.