December 15 build not working on firefox 44 beta

[rayman89]

Not working at all. There are no tab menu items. It does not auto unload tabs or anything.

[linvinus]

please try this patch https://github.com/linvinus/suspendtab/commit/7191b36b9042b026363f511c5b2d7d30d756ec98

[rayman89]

Is this patch based on nightly version of suspendtab tab or release? I tested it on nightly and tab menus now are there but they don't do anything..

[linvinus]

patch based on git master version, you may clone my forked version and then build as usual. if suspendtab appear in menu then it should working. try to open several tabs, then on current active tab, run "suspend other tabs", after that click on any other tab, if it was suspended then you will see page loading progress same as you just open it first time.

[rayman89]

Sorry I'm not a dev I don't know how to do that. Could you provide me with either the already patched xpi or the "git master version" xpi?

I tested "suspend other tabs" on a clean profile and it didn't work. Auto suspend tabs doesn't work either. Wouldn't be the first add-on i tested to have a menu without functionality.

[linvinus]

there is ftp://linvinus.ru/forum/firefox/suspendtab_noupdate.xpi

[rayman89]

Tested that and it's the same. It does not work. The context menu on the tabs do show but they do nothing and the tabs do not automatically unload/suspend either. (it was tested on a new clean profile firefox 44 beta x64 on windows 7 x64)

[linvinus]

you are right! there is updated version ftp://linvinus.ru/forum/firefox/suspendtab_noupdate.xpi now it working, changes available there https://github.com/linvinus/suspendtab/commit/5f7d4008ffc1d591a39cd4fb38f4e04fd33b14fe

[rayman89]

When a page is suspended and you try to load it it wont render the page even if you reload the tab it appears to be loading but after it finishes there is still no webpage showing it's just the default white background with nothing on it. Trying to load an other url on that tab wont work either it stays always white.

[linvinus]

yep, thanks for testing, after while i also observe that. hope to resolve that. suspend is working, resume is buggy.

[linvinus]

please try new version version ftp://linvinus.ru/forum/firefox/suspendtab_noupdate.xpi changes https://github.com/linvinus/suspendtab/commit/35d36f170081fb6cf89b7e99505741f5d949af19 on my system working fine

[rayman89]

Has the same exact issue as the one before.(it was tested on a new clean profile firefox 44 beta x64 on windows 7 x64)

[linvinus]

finally now FF 40 - 44 working. please try new version version ftp://linvinus.ru/forum/firefox/suspendtab_noupdate.xpi changes https://github.com/linvinus/suspendtab/commit/56fa835c10ea0f745ac7e26c3c0d57cdba501a44

don't forget to disable automatically update in extension preferences!!! extensions->suspendtab->More->Automatic Updates=Off

[rayman89]

Works properly now. Thanks a lot.

[piroor]

I've feedbacked some changes from https://github.com/linvinus/suspendtab/commits/master

[linvinus]

what about this changes? https://github.com/linvinus/suspendtab/commit/35d36f170081fb6cf89b7e99505741f5d949af19

as i understand now FF will call SessionStoreInternal.restoreTabContent(aTab); by it self on tab select event if browser.__SS_restoreState = TAB_STATE_NEEDS_RESTORE;

[piroor]

Thanks! I missed the point. 9e905e850f9531156d74e47a57bbedee7c1866ed is my version. For compatibility I think I should keep other codes to dispatch custom events.

[linvinus]

ok, it is up to you.

also it will be good to save tab icon, for suspended tab, so it will looks the same as unsuspended.

for example, currently suspended tabs looks differently, on the left suspended tabs without icon, on the right not suspended.

(changes on line 350 in suspendtab-internal.js)

    // Update the persistent tab state cache with |state| information.
    TabStateCache.update(browser, {
          history: {entries: state.entries, index: state.index},
          scroll: state.scroll || null,
          storage: state.storage || null,
          formdata: state.formdata || null,
          disallow: state.disallow || null,
          pageStyle: state.pageStyle || null

      // This information is only needed until the tab has finished restoring.
      // When that's done it will be removed from the cache and we always
      // collect it in TabState._collectBaseTabData().
      image: state.image || "",
      userTypedValue: state.userTypedValue || "",
      userTypedClear: state.userTypedClear || 0
    });

[piroor]

Thanks, merged at b20d44a6d404d547ed50e5fa93c0a149ea198e0f.

[linvinus]

this bug should be closed as resolved, if author don't agree with that then he could reopen it.

[piroor]

Now it's under doogfooding. I'll release a new version, if it works correctly on my daily environment.

[linvinus]

on my system also working fine