restartless icon indicating copy to clipboard operation
restartless copied to clipboard

New Customize Toolbar UI in FF nightly

Open minj opened this issue 10 years ago • 1 comments

Apparently they changed FF UI in FF nightly. It breaks ToolbarItem.js

in https://github.com/piroor/restartless/blob/master/modules/lib/ToolbarItem.js#L235 toolbar.id === 'nav-bar'

however this._document.getElementById(items[index]) in https://github.com/piroor/restartless/blob/master/modules/lib/ToolbarItem.js#L248 returns an element whose id === 'nav-bar-customization-target' It's a <hbox> whose parentNode is #nav-bar

obviously this causes insertBefore() to fail

@@ -232,7 +232,7 @@ ToolbarItem.prototype = {

    _checkInsertedInOtherPlace : function()
    {
-       var toolbar = this._getNodeByXPath('/descendant::*[local-name()="toolbar" and contains(concat(",",@currentset,","), '+this.id.quote()+')]');
+       var toolbar = this._getNodeByXPath('/descendant::*[local-name()="hbox" and contains(concat(",",@currentset,","), '+this.id.quote()+')]');
        if (!toolbar)
            return false;

Prevents an exception but no toolbar button is displayed so there maybe other underlying issues...

Decided to open an issue as a heads up but this might be too soon to look at before it hits aurora

minj avatar Nov 19 '13 16:11 minj