Phil Pirozhkov
Phil Pirozhkov
This will become green when https://github.com/rspec/rspec-core/pull/2880 is merged. I have some time for Expectations counterpart PR, let's see how all three work together. Still, preliminary code review is appreciated.
Thanks for reviving this and the detailed analysis. > logging library which provides a `Log.warn` method Do they provide it through `method_missing`? > show a warning when such a double...
Nice find, thanks for reporting. Would it make sense to add JRuby check to `RUBY_VERSION < "2.3"`? Is there a more real-life spec that we could add to prevent regression?...
@marcotc ping
```diff - if RUBY_VERSION < "2.3" || backed_up_method_owner[method_name.to_sym] == self + if RUBY_VERSION < "2.3" || RSpec::Support::Ruby.jruby? || backed_up_method_owner[method_name.to_sym] == self ``` made your spec green on `jruby-head` (jruby 9.3.0.0-SNAPSHOT...
The example https://github.com/rspec/rspec-mocks/blob/018d0d54a0ecaed259fd4eac5f151c51abb57b1d/spec/rspec/mocks/any_instance_spec.rb#L204 is a bit different. Here, there's no even a parent class involved. But there is: - prepend - double stubbing - double reset without any one of...
@jamesdabbs-procore ping!
I've tried playing with the code, and couldn't get those `or` examples to work.
@eLod did you reach the enlightenment point? Do you need some guidance here?
@etipton Pull request is welcome.