Phil Pirozhkov
Phil Pirozhkov
Frankly speaking, I found this part of the original PR less useful than the `key: true` `:key` cop. Last time I ran the cop on `real-world-rspec`, sorting was doubtfully useful...
> Which original PR do you mean? [This part](https://github.com/rubocop/rubocop-rspec/compare/52c205d301bfadf6e0cfac812c3ed62dbab5ca80..dfc40a173f0617f05b10d52259acaa6404d2c660#diff-72172d797d98f9a8586056c578546fdefc8b55e8bfb5b6d2431246ddbbd49f91L4179-L4207) of #1325 that was later removed by the author. [Here](https://github.com/rubocop/rubocop-rspec/pull/1325#discussion_r922896282) I suggested extracting that part into a separate cop, but that...
> I suggested extracting that part into a separate cop The reason I've suggested extracting to another cop was my opinion that a cop that would transform `focus: true` to...
> if there is named subject in use, it's better to be left explicit, as you can't use the name with the implicit syntax, and there might be a reason...
Thank you, @ydah !
Even though it's related to testing, we mostly keep cops that look after the RSpec coding style, and related test libraries like FactoryBot, Capybara, and RSpec Rails with their DSLs....
> if any other testing block goes unclosed in any test, all the other tests will be overridden by unclosed testing block mode Why? `config.before` (and its default scope is...
`RSpec.configure do` is done in `spec/spec_helper.rb`/`spec/rails_helper.rb`, so it's project level. I do not suggest to use `RSpec.configure` in the beginning of the spec files, I only used it for you...
Have you considered using `it_behaves_like` instead of `include_examples`, @gburgett ? The difference is that the former wraps all shared examples in an example group, and `let`s defined in it take...
@gburgett May I kindly ask you to check if #1413 keeps your specs green after autocorrection?