Phil Pirozhkov

Results 668 comments of Phil Pirozhkov

The gem [includes itself](https://github.com/GeorgeKaraszi/ActiveRecordExtended/blob/33000ed962205699768222e93179507d87c27f01/lib/active_record_extended/query_methods/unionize.rb#L249): ```ruby ActiveRecord::Relation.prepend(ActiveRecordExtended::QueryMethods::Unionize) ``` To my best knowledge, this is prone to load order errors. To be a good citizen, Railtie mechanism would better be used, e.g:...

> avoid developers from having to understand That would be ideal. > automatically disabling transaction when using non-transaction compatible methods Do you think it is possible? As I understand it,...

I was getting curious why my `add_index` was `CONCURRENTLY` even though I didn't specify that explicitly, and why it was running outside a transaction even though there were no `disable_ddl_transaction!`...

Nice, delighted to hear that! I thought I might be missing something, just because our DB setup is pretty straightforward and the load is quite low.

There were a few internal cops as far as I remember. 1. [Models as arguments](https://github.com/toptal/active-job-style-guide#active-record-models-as-arguments). As I recall, it was prone to false positives. E.g. `stripe_id` is not an id...

I would suggest you to open a ticket against `jekyll-multiple-languages-plugin`, @HatemKhattab . They seem to load and parse YAML files by hand, and their expected Ruby de-facto standard file format...

It's a controversial topic. https://github.com/rubocop/ruby-style-guide/pull/730 has been recently merged. Also related https://github.com/rubocop/ruby-style-guide/pull/785