Phil Pirozhkov

Results 566 comments of Phil Pirozhkov

> is it acceptable to have 2+3+add method .in_range(from..to)? Shortly: no. The introduction of this new method is orthogonal to the fixes, and can be done separately. Adding a new...

There's one more issue I could spot: ```ruby r = double expect(r).to receive(:foo).at_most(:once).and_return(1, 2) r.foo r.foo ``` surprisingly, this passes.

This seems like an unrelated issue @btalbot .Can you please open a separate issue providing a reproduction example? So are you saying that if you `File.read('someotherfile')` in your spec, it...

@vibro Thanks for reporting. > started failing with the new version of rspec-mocks released What was the previous version of `rspec-mocks` that worked as expected for you?

@vibro At a glance, I could find #1394. Could you read comments there to see if there's an explanation to this behavioural change. @rus-max What is the Ruby version that...

@rus-max I suggest you to check #1473 for some information regarding `instance_double(...)` changes.

> An even futher odditiy is it seems to be specifically the Hash.new that is causing the issue, a non empty hash does not trigger the snippet. ```ruby delegate({}) #...

Would you be interested in taking another approach to the problem @sponomarev ?

@fledman the problem with passing a `strict` argument to predicate matchers is that [the underlying predicate can accept parameters as well, and we pass them over to it](https://relishapp.com/rspec/rspec-expectations/v/3-10/docs/built-in-matchers/predicate-matchers), e.g. `have_key(:foo)`/`be_multiple_of(3)`....