Phil Pirozhkov
Phil Pirozhkov
@denzelem A cop would surely be nice to have. A PR is welcome. > So what do you expect from this cop? I'd say the cop should raise an offence...
> An alternative way to enforce this would be to configure Rails to raise on deprecation warnings: ```ruby config.active_support.deprecation = :raise ``` It's not always feasible I suppose, e.g. if...
@fatkodima Do you think it makes sense to run the new cop against https://github.com/eliotsykes/real-world-rails to check if there are errors, and check for false positives? I can do this for...
That cop is licensed with MIT, so my guess is that we can just borrow it. The incompatibility seems to be due to [the hard version requirement](https://github.com/carolineartz/rubocop-rails-order_model_macros/blob/3f0a70706531bda7e1bbab3cc927daa46309e6de/rubocop-rails-order_model_macros.gemspec#L21) and may not...
I ended up creating https://github.com/pirj/rspec-enqueue_sidekiq_job Since we don’t use Sidekiq directly in my current project, I’m not so interested in actively maintaining the repo further. I’ll be happy if you...
I think this is unnecessary, the PR is good as is. The point in preferring `[]` is to fail during the development phase making typos in attribute names obvious. I...
@dvandersluis We came up with an idea to obsolete cops without actually removing them, see https://github.com/rubocop/rubocop-rspec/pull/1519. The idea is to: - rename the cop - [inherit the old cop from...
> can we use assignment? That was [the initial approach](https://github.com/rubocop/rubocop-rspec/compare/c820abd1853c0c98b66644439c98eebc717ba76e..ab3b50f35c60ac7a167d48608b35df6ba99d5129), I can't recall why I've switched to inheriting, I'll check if it works.
> can we use assignment (NewNameCop = ObsoleteNameCop) instead of inheritance (class NewNameCop < ObsoleteNameCop) ? Probably, but the doc generation task breaks. Our goal is to keep the documentation...
Luckily, there's a workaround: ```ruby # !@parse # # Some cop docs # class NewNameCop < ::RuboCop::Cop::Base; end NewNameCop = ObsoleteNameCop ``` See https://github.com/rubocop/rubocop-rspec/pull/1519 for more details.