Phil Pirozhkov

Results 628 comments of Phil Pirozhkov

> > when non-resourceful methods are present in the controller > Do you mean spec/rubocop/cop/rails/action_order_spec.rb:70 Please accept my apologies, missed that example completely 🙈 👍

@mollerhoj ping

[The cop's doc](https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsredundantpresencevalidationonbelongsto) states: > Since Rails 5.0 the default for belongs_to is optional: false unless config.active_record.belongs_to_required_by_default is explicitly set to false. The presence validator is added automatically, and explicit...

Good point and a very interesting observation, @mockdeep. On a side note, you may like the approach taken in [`database_validations`](https://github.com/toptal/database_validations). Wondering why does Rails fetch the whole record `SELECT *...

Even though (https://docs.rubocop.org/rubocop-rails/): > RuboCop Rails [ is ] A RuboCop extension focused on enforcing Rails best practices and coding conventions. and (https://docs.rubocop.org/rubocop/1.20/index.html#overview): > A long-term goal of RuboCop (and...

What if we just narrow down the first iteration of this to cover model association methods? Those are the ones that have numerous options passed to them fairly regularly. I...

Another option that does not require configuration is inspecting `db/*schema.rb` file*s*. Plural because there can many with multiple DB support.

Oh, that won't work, as schemas have all legacy columns. Yes, I believe the path taken in #277 is fine.