Phil Pirozhkov

Results 628 comments of Phil Pirozhkov

> + RESTRICT_ON_SEND = %i[ > Because of the configurable language, it's hard to really restrict the send. > As it might be possible to define different configuration in different...

Speaking of the name, I think we can refer to the upcoming [Cop naming guidelines](https://github.com/rubocop/rubocop/pull/10725/files#diff-d215eaa340849c3e72defb154136bcb8e2238d47e34236eaabd7e09b9b334e1bR40). I'd suggest `RSpec/UnorderedMetadata`.

Checked against [`real-world-rspec`](https://github.com/pirj/real-world-rspec): ``` 57497 files inspected, 230 offenses detected, 230 offenses autocorrectable 1 error occurred: An error occurred while RSpec/SortMetadata cop was inspecting /Users/pirj/source/real-world-rspec/rspec-core/spec/rspec/core/metadata_spec.rb:51:14. ```

@leoarnold Is there anything left you want to adjust in this PR before it gets merged?

Superseded by #1378 @leoarnold I encourage you to revive the original part of this PR related to changing the style `focus: true` `:focus` as a separate cop.

Fair enough, especially given that negated expectations are not trivial to combine into one. Would you like to submit a PR? I'd expect: 1. Taking parts from `lib/rubocop/cop/rspec/repeated_example.rb` that adds...

I withdraw [my proposal of introducing `IgnoreItsWithSameAttribute`](https://github.com/rubocop/rubocop-rspec/issues/879#issuecomment-605687818), as it seems to make sense to make this the default.

Note for the future researchers. Even though [`its` accepts arbitrary arguments](https://github.com/rspec/rspec-its/blob/aca1c95014578cfc43b27dc0ff259909e4c4cd87/lib/rspec/its.rb#L123), the "docstring" of the generated example [is explicitly set to `nil`](https://github.com/rspec/rspec-its/blob/aca1c95014578cfc43b27dc0ff259909e4c4cd87/lib/rspec/its.rb#L171), so all of those arguments can be treated...

Would you like to submit a PR fixing this, @arg ?