Phil Pirozhkov

Results 628 comments of Phil Pirozhkov

Can you provide some reproducible scenario, @gbudiman @sAnti09 ? Something involving ruby version installation and a repository that crashes would do.

Related to #221, (will supposedly be) fixed in #226.

I think [this rule](https://github.com/rubocop-hq/ruby-style-guide/#method-invocation-parens-internal-dsl) applies to FactoryGirl. So if there's no such cop in RuboCop itself (couldn't find one quickly), it might be a good idea to implement it there.

@vmakoed Pull request is always welcome! I guess this cop should have a style option whether to set parantheses or not.

Since the gem works fine, we could recommend it as an optional dependency for this specific case. To circumvent the brittleness, can you provide more information on what internal API...

Nice! Do you mind throwing in a spec that would indicate how it behaves in action?

The failing example is flaky, due to order dependency. If the example that define the "PvP" acronym runs first, that the other one fails. I suggest adding metadata to the...

@bquorning I was a secret admirer/dreamer of a plain Ruby RuboCop configuration, especially after our [DSL configuration extension](https://github.com/rubocop/rubocop-rspec/pull/956) and some [later problems](https://github.com/rubocop/rubocop-rspec/pull/1181) with [merging arrays in YAML](https://github.com/rubocop/rubocop/issues/9325). Did you have...

We don't have a formal checklist for changing the defaults, but if I had to come up with it, it would be: - [ ] make sure to only change...

Found a mistake in the example, "also good" part: ```ruby Strict: true, EnforcedStyle: inflected (default) # bad expect(foo.something?).to be_truthy # good expect(foo).to be_something # also good - It checks "true"...