Phil Pirozhkov

Results 628 comments of Phil Pirozhkov

Hi @dblandin Can you please share your `config/crystalball_data.yml`?

@dblandin I'm truly sorry, I meant `config/crystalball.yml`. Can you please paste it? It seems there's an error while loading this config file.

Would it make sense to configure this cop to only include feature/system spec paths. What do you think? > this cop should only look for given calls immediately inside of...

Please accept my apologies. That must have been `before` inside `before`, not `let`. Alright, it's an edge case, but worth and possible to fix. I suggest adding a check that...

Hey @ojab ! Indeed, this is problematic. [`mail` testing doc](https://github.com/mikel/mail#using-mail-with-testing-or-specing-libraries). I'm thinking if limiting those cops inspection to only `subject` that is a defied directly in an example group block...

> limiting the check to block and blockpass nodes Brilliant idea, that should do it. I couldn't quickly find if `mail` supports `subject` with a block, apparently it doesn't.

@ojab Would you like to send a PR to fix this? #1224 might give some hints for the change.