kubernetes-vagrant-coreos-cluster icon indicating copy to clipboard operation
kubernetes-vagrant-coreos-cluster copied to clipboard

Published 20 hours ago • verified publisher icon pires

Support the Kubernetes Metrics Server

Open abcdabcd987 opened this issue 7 years ago • 4 comments

First of all, thank you Mr. Pires, for this very handy Vagrant project.

I added the support of the Kubernetes Metrics Server. plugins/metrics-server/ is from metrics-server/deploy/1.8+/. And I have to make some changes to the manifests/master-apiserver.yaml according to this comment.

I've tested it on Mac. But I'm not sure if it works on Windows. And also not sure about RBAC.

abcdabcd987 avatar Oct 26 '18 21:10 abcdabcd987

@abcdabcd987 thank you for sending this PR! Following the merge of #320, it now has conflicts which must be resolved. Could you please resolve them?

bmcustodio avatar Oct 27 '18 17:10 bmcustodio

resolved.

abcdabcd987 avatar Oct 27 '18 18:10 abcdabcd987

Thanks a lot for your kind words and contributions, @abcdabcd987.

The commit log shows that there is a merge commit. Can you rebase instead, so it's just one clean commit?

pires avatar Oct 28 '18 16:10 pires

rebased.

abcdabcd987 avatar Oct 28 '18 17:10 abcdabcd987