docker-elasticsearch icon indicating copy to clipboard operation
docker-elasticsearch copied to clipboard

Use ENV to add elasticsearch-keystore entries

Open patricktoelle opened this issue 7 years ago • 10 comments

patricktoelle avatar Jan 18 '18 13:01 patricktoelle

Is this ready to be merged?

jjungnickel avatar Jan 25 '18 12:01 jjungnickel

@jjungnickel I'm having second thoughts about this.

pires avatar Jan 26 '18 10:01 pires

@pires Let's talk about it :-)

jjungnickel avatar Jan 26 '18 10:01 jjungnickel

Would love to but my day job is sucking a lot of my energy and this is low priority. I am very sorry for that. I'll sleep on this over the weekend. Ping me next week.

pires avatar Jan 26 '18 10:01 pires

Don't worry, we've all been there. We already have this integrated in our private repo and image, just wanted to push this upstream, so there's no actual pressure ;-)

jjungnickel avatar Jan 26 '18 10:01 jjungnickel

Hello I am interested in this evolution too, since it has been approved can someone solve the conflict and merge this in the repo?

yciabaud avatar Apr 12 '18 08:04 yciabaud

Just rebased onto master

patricktoelle avatar Apr 17 '18 11:04 patricktoelle

@yciabaud @jjungnickel can you please try this and let me know?

pires avatar Apr 17 '18 16:04 pires

That's exactly what I did on my repo, will check tomorrow to be sure. Thanks

yciabaud avatar Apr 17 '18 17:04 yciabaud

LGTM

jjungnickel avatar May 09 '18 08:05 jjungnickel