security-growler icon indicating copy to clipboard operation
security-growler copied to clipboard
verified publisher icon pirate

Linux and Gnome compatibility

Open nmaggioni opened this issue 9 years ago • 9 comments

  • [X] Environment integration
    • [X] Logfiles path
    • Gnome
      • [X] Notifications
      • [X] ~~Menu applet~~
  • [X] Sources integration
    • [X] systemd
  • [X] Parsers integration
    • [X] ~~connections~~ N/A without third-party software.
    • [X] ~~ftp~~ Too many software choices available.
    • [X] ~~Ostiarius~~ N/A under Linux.
    • [X] ~~portscan~~ N/A without third-party software.
    • [X] ssh
    • [X] sudo
    • [X] ~~vnc~~ Too many software choices available.

nmaggioni avatar May 02 '16 13:05 nmaggioni

I think I'm quite done with this PR: unfortunately many functions require additional third-party software to work properly (portscan detection, vnc/ftp/generic port connections) and some are just incompatible (Ostiarius).

A menu applet might be a bit useless with this restricted set of functionalities, I think it'd be better to just have a runnable script under Linux.

nmaggioni avatar May 05 '16 07:05 nmaggioni

I love it! I'm about ready to merge it after some tiny changes. Maybe for v3.5 I'll think about splitting the mac and linux shell scripts entirely. We could call one linux.sh and the other mac.sh, and have the Platypus app only load mac.sh, that way it's super clear to the user which one they need to be running.

A couple quick questions, what version(s) of Linux are you testing this on? And did you manage to test the Platypus app on a mac again with all these changes? If not no worries, I'll check out the branch and recompile the Platypus app to make sure everything still works.

Thanks for all the hard work, this looks awesome and I'm excited that SC will have Linux support soon!

pirate avatar May 12 '16 16:05 pirate

I'm testing this on Manjaro, an Arch Linux derivative.

Unfortunately I didn't manage to get my hands on an OS X machine, so I can't really speak out for that OS... But I've been careful to avoid tweaking core functionalities of SG too much, so my best guess is that everything should work as fine as before - given that

from sys import platform as _platform

is the only single point of failure. If on OS X that gives "Darwin" as the docs say, the script shouldn't implode.

nmaggioni avatar May 12 '16 21:05 nmaggioni

Synced and ready to merge :+1:

nmaggioni avatar Feb 24 '17 18:02 nmaggioni

@pirate Any update on this? I'd love to see this on Linux. :smile:

Fred-Barclay avatar Mar 29 '17 15:03 Fred-Barclay

As it stands if I just merge this branch it'll break OS X support in a couple places. I've checked out the branch and I'm debugging it now, there are a couple things left and and a few behavior tweaks I want to make too. I'll keep you guys posted, sorry for the long delay in getting to this!

pirate avatar Apr 11 '17 19:04 pirate

No worries at all, let me know if I can do something.

nmaggioni avatar Apr 11 '17 19:04 nmaggioni

@pirate Since growler is temporarily on hold, would you mind me forking it and developing it with more of an eye to the Linux features? I don't have a Mac so I wouldn't be able to maintain the macOS portions (I might end up removing the macOS specific stuff unless someone else could handle that part).

Fred-Barclay avatar Dec 31 '17 03:12 Fred-Barclay

@Fred-Barclay go for it, although I think my original architecture is a bit flawed and could be improved. It could be better designed with a more robust event loop and ability to handle sources of different types in a clean manner.

You're welcome to copy the code or just copy the ideas and rewrite it from scratch on Linux, whatever is easiest. Also take a look at https://github.com/benjojo/PushAlotAuth

pirate avatar Dec 31 '17 03:12 pirate